Query : Add support for final GroupBy operator #28972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/whygroupby
branch
from
9067e43 to
74f7799
Compare
roji
approved these changes
Sep 11, 2022
| object IEnumerator.Current | ||
| => Current!; | ||
|
|
||
| public bool MoveNext() |
There was a problem hiding this comment.
Any potential to DRY across the different querying enumerables (in the future)? If so maybe a tracking issue...
There was a problem hiding this comment.
Core enumerators have different mechanism to iterate wrt related data and grouping. There can be some refactoring to introduce hierarchy though it could have some perf impact.
There was a problem hiding this comment.
Yeah, i agree we don't want to regress perf for this. Just something to think about for the future in case it's relevant.
| // It should be only at top-level otherwise GroupBy won't be final operator. | ||
| // Cloning skips it altogether (we don't clone top level with GroupBy) | ||
| // Pushdown should null it out as if GroupBy was present was pushed down. | ||
| private List<(ColumnExpression Column, ValueComparer Comparer)>? _preGroupByIdenifier; |
There was a problem hiding this comment.
Suggested change
| private List<(ColumnExpression Column, ValueComparer Comparer)>? _preGroupByIdenifier; | |
| private List<(ColumnExpression Column, ValueComparer Comparer)>? _preGroupByIdentifier; |
| // This indicates that GroupBy was not condensed out of grouping operator. | ||
| throw new InvalidOperationException(CoreStrings.TranslationFailed(query.Print())); | ||
| } | ||
| if (!(groupByNavigationExpansionExpression.Source is MethodCallExpression methodCallExpression |
| @@ -134,6 +134,9 @@ | |||
| <value>Transactions are not supported by the in-memory store. See http://go.microsoft.com/fwlink/?LinkId=800142</value> | |||
| <comment>Warning InMemoryEventId.TransactionIgnoredWarning</comment> | |||
| </data> | |||
| <data name="NoncomposedGroupByNotSupported" xml:space="preserve"> | |||
There was a problem hiding this comment.
nit:
Suggested change
| <data name="NoncomposedGroupByNotSupported" xml:space="preserve"> | |
| <data name="NonComposedGroupByNotSupported" xml:space="preserve"> |
smitpatel
force-pushed
the
smit/whygroupby
branch
from
74f7799 to
e253d54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19929